Don't delete resource folder while clean/rebuild#424
Merged
Conversation
smadala
reviewed
May 23, 2018
smadala
left a comment
smadala
left a comment
Contributor
There was a problem hiding this comment.
Test this on loc machine.
smadala
approved these changes
May 23, 2018
smadala
left a comment
smadala
left a comment
Contributor
There was a problem hiding this comment.
Add all your findings for why the remove this target won't impact other scenarios to PR description.
Contributor
|
Update the title too. |
jayaranigarg
changed the title
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had 2 ways to fix this : clean conditionally or not clean at all. We are choosing to not clean at all because in large project systems rebuilding happens parallelly and one project trying to access it while other trying to clean it might create troubles.
Doing a clean/rebuild on loc machines, deletes and re-creates "en" (culture specific folder) and hence there will be no such scenario where this "en" folder will be empty which we need to cleanup. Additionally, creating/deleting the "en" folder should be a build/clean/rebuild functionality and should not be tied to MSTestv2 in any way.
#197